workflows: use bash shell explicitly

This forces better error handling as described in [1].

Without this change, bash would *not* run with `-o pipefail`, which
means some errors go unnoticed. By naming `bash` explicitly, `-o
pipefail` is enabled.

1:
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#defaultsrunshell
This commit is contained in:
Wolfgang Walther 2025-06-10 21:59:31 +02:00
parent c4949d642c
commit 0f5e504f9e
No known key found for this signature in database
GPG Key ID: B39893FA5F65CAE1
19 changed files with 76 additions and 0 deletions

View File

@ -14,6 +14,10 @@ permissions:
issues: write issues: write
pull-requests: write pull-requests: write
defaults:
run:
shell: bash
jobs: jobs:
backport: backport:
name: Backport Pull Request name: Backport Pull Request

View File

@ -17,6 +17,10 @@ concurrency:
permissions: permissions:
pull-requests: write pull-requests: write
defaults:
run:
shell: bash
jobs: jobs:
check: check:
name: cherry-pick-check name: cherry-pick-check

View File

@ -12,6 +12,10 @@ concurrency:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
nixos: nixos:
name: fmt-check name: fmt-check

View File

@ -15,6 +15,10 @@ concurrency:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
shell-check: shell-check:
strategy: strategy:

View File

@ -35,6 +35,10 @@ concurrency:
permissions: {} permissions: {}
defaults:
run:
shell: bash
env: env:
OWNERS_FILE: ci/OWNERS OWNERS_FILE: ci/OWNERS
# Don't do anything on draft PRs # Don't do anything on draft PRs

View File

@ -22,6 +22,10 @@ concurrency:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
base: base:
name: Trigger jobs name: Trigger jobs

View File

@ -12,6 +12,10 @@ concurrency:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
eval-aliases: eval-aliases:
name: Eval nixpkgs with aliases enabled name: Eval nixpkgs with aliases enabled

View File

@ -22,6 +22,10 @@ concurrency:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
prepare: prepare:
name: Prepare name: Prepare

View File

@ -17,6 +17,10 @@ permissions:
issues: write # needed to create *new* labels issues: write # needed to create *new* labels
pull-requests: write pull-requests: write
defaults:
run:
shell: bash
jobs: jobs:
labels: labels:
name: label-pr name: label-pr

View File

@ -15,6 +15,10 @@ concurrency:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
nixpkgs-lib-tests: nixpkgs-lib-tests:
name: nixpkgs-lib-tests name: nixpkgs-lib-tests

View File

@ -24,6 +24,10 @@ concurrency:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
nixos: nixos:
name: nixos-manual-build name: nixos-manual-build

View File

@ -16,6 +16,10 @@ concurrency:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
nixpkgs: nixpkgs:
name: nixpkgs-manual-build name: nixpkgs-manual-build

View File

@ -12,6 +12,10 @@ concurrency:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
tests: tests:
name: nix-files-parseable-check name: nix-files-parseable-check

View File

@ -20,6 +20,10 @@ permissions: {}
# We don't use a concurrency group here, because the action is triggered quite often (due to the PR edit trigger), and contributors would get notified on any canceled run. # We don't use a concurrency group here, because the action is triggered quite often (due to the PR edit trigger), and contributors would get notified on any canceled run.
# There is a feature request for suppressing notifications on concurrency-canceled runs: https://github.com/orgs/community/discussions/13015 # There is a feature request for suppressing notifications on concurrency-canceled runs: https://github.com/orgs/community/discussions/13015
defaults:
run:
shell: bash
jobs: jobs:
check: check:
name: nixpkgs-vet name: nixpkgs-vet

View File

@ -8,6 +8,10 @@ on:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
fail: fail:
if: | if: |

View File

@ -16,6 +16,10 @@ on:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
periodic-merge: periodic-merge:
if: github.repository_owner == 'NixOS' if: github.repository_owner == 'NixOS'

View File

@ -16,6 +16,10 @@ on:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
periodic-merge: periodic-merge:
if: github.repository_owner == 'NixOS' if: github.repository_owner == 'NixOS'

View File

@ -12,6 +12,10 @@ on:
required: true required: true
type: string type: string
defaults:
run:
shell: bash
jobs: jobs:
merge: merge:
runs-on: ubuntu-24.04-arm runs-on: ubuntu-24.04-arm

View File

@ -22,6 +22,10 @@ concurrency:
permissions: {} permissions: {}
defaults:
run:
shell: bash
jobs: jobs:
request: request:
name: Request name: Request