talexander/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Releases Activity

electron_32: fix log spam when building on x86_64-linux as well

Browse Source 
Follow-up to ce04dc5edc28423ea4cb3a63b13aa40a912e1b8f.

Turns out the very same log spam is happening on x86_64-linux and not
just on aarch64-linux but hydra.nixos.org does not enforce the log limit
of 64mb for some reason.

I should have figured.
This commit is contained in:
emilylange 2025-02-15 20:37:12 +01:00
parent 6dc8694a88
commit 3f514d36a7
No known key found for this signature in database
GPG Key ID: 0AD773CE46FD0F87
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkgs/development/tools/electron/common.nix
View File

@ -161,13 +161,14 @@ in
env = env =
base.env base.env
// lib.optionalAttrs (lib.versionOlder info.version "33" && stdenv.hostPlatform.isAarch64) { // lib.optionalAttrs (lib.versionOlder info.version "33") {
# Hydra fails to build electron_32.aarch64-linux as of 2025-01-05 due to # Hydra fails to build electron_32.aarch64-linux as of 2025-01-05 due to
# clang spamming deprecation warnings mid-build, causing the build log to # clang spamming deprecation warnings mid-build, causing the build log to
# grow beyond the limit of 64mb and then getting killed by Hydra. This # grow beyond the limit of 64mb and then getting killed by Hydra. This
# renders our clang both too old for the latest chromium without the use # renders our clang both too old for the latest chromium without the use
# of -Wno-unknown-warning-option and also too new for electron_32 (M128). # of -Wno-unknown-warning-option and also too new for electron_32 (M128).
# For some reason, this is exclusively happening on aarch64-linux. To # For some reason, the log size limit appears to only be enforced on
# aarch64-linux. x86_64-linux happily succeeds to build with ~180mb. To
# unbreak the build on h.n.o, we simply disable those warnings for now. # unbreak the build on h.n.o, we simply disable those warnings for now.
# https://hydra.nixos.org/build/283952243 # https://hydra.nixos.org/build/283952243
NIX_CFLAGS_COMPILE = base.env.NIX_CFLAGS_COMPILE + " -Wno-deprecated"; NIX_CFLAGS_COMPILE = base.env.NIX_CFLAGS_COMPILE + " -Wno-deprecated";