Revert "modules/virtualisation: add shared options, merge various diskSize options" (#340894)

Breaks evaluation of all nixos tests, and is therefore a channel blocker.

nixos/maintainers/scripts/ec2/amazon-image.nix

@@ -1,50 +1,24 @@
-{
+{ config, lib, pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 let
-  inherit (lib)
+  inherit (lib) mkOption optionalString types versionAtLeast;
-    mkOption
-    optionalString
-    types
-    versionAtLeast
-    ;
   inherit (lib.options) literalExpression;
   cfg = config.amazonImage;
   amiBootMode = if config.ec2.efi then "uefi" else "legacy-bios";
-  virtualisationOptions = import ../../../modules/virtualisation/virtualisation-options.nix;
 
-in
+in {
-{
+
-  imports = [
+  imports = [ ../../../modules/virtualisation/amazon-image.nix ];
-    ../../../modules/virtualisation/amazon-image.nix
-    virtualisationOptions.diskSize
-    (lib.mkRenamedOptionModuleWith {
-      sinceRelease = 2411;
-      from = [
-        "virtualisation"
-        "amazonImage"
-        "sizeMB"
-      ];
-      to = [
-        "virtualisation"
-        "diskSize"
-      ];
-    })
-  ];
 
   # Amazon recommends setting this to the highest possible value for a good EBS
   # experience, which prior to 4.15 was 255.
   # https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/nvme-ebs-volumes.html#timeout-nvme-ebs-volumes
   config.boot.kernelParams =
-    let
+    let timeout =
-      timeout =
+      if versionAtLeast config.boot.kernelPackages.kernel.version "4.15"
-        if versionAtLeast config.boot.kernelPackages.kernel.version "4.15" then "4294967295" else "255";
+      then "4294967295"
-    in
+      else  "255";
-    [ "nvme_core.io_timeout=${timeout}" ];
+    in [ "nvme_core.io_timeout=${timeout}" ];
 
   options.amazonImage = {
     name = mkOption {
@@ -60,30 +34,30 @@ in
           }
         ]
       '';
-      default = [ ];
+      default = [];
       description = ''
         This option lists files to be copied to fixed locations in the
         generated image. Glob patterns work.
       '';
     };
 
+    sizeMB = mkOption {
+      type = with types; either (enum [ "auto" ]) int;
+      default = 3072;
+      example = 8192;
+      description = "The size in MB of the image";
+    };
+
     format = mkOption {
-      type = types.enum [
+      type = types.enum [ "raw" "qcow2" "vpc" ];
-        "raw"
-        "qcow2"
-        "vpc"
-      ];
       default = "vpc";
       description = "The image format to output";
     };
   };
 
-  config.virtualisation.diskSize = lib.mkDefault (3 * 1024);
+  config.system.build.amazonImage = let
-  config.virtualisation.diskSizeAutoSupported = !config.ec2.zfs.enable;
+    configFile = pkgs.writeText "configuration.nix"
-
+      ''
-  config.system.build.amazonImage =
-    let
-      configFile = pkgs.writeText "configuration.nix" ''
         { modulesPath, ... }: {
           imports = [ "''${modulesPath}/virtualisation/amazon-image.nix" ];
           ${optionalString config.ec2.efi ''
@@ -97,19 +71,14 @@ in
       '';
 
     zfsBuilder = import ../../../lib/make-multi-disk-zfs-image.nix {
-        inherit
+      inherit lib config configFile pkgs;
-          lib
-          config
-          configFile
-          pkgs
-          ;
       inherit (cfg) contents format name;
 
       includeChannel = true;
 
       bootSize = 1000; # 1G is the minimum EBS volume
 
-        rootSize = config.virtualisation.diskSize;
+      rootSize = cfg.sizeMB;
       rootPoolProperties = {
         ashift = 12;
         autoexpand = "on";
@@ -150,19 +119,14 @@ in
     };
 
     extBuilder = import ../../../lib/make-disk-image.nix {
-        inherit
+      inherit lib config configFile pkgs;
-          lib
-          config
-          configFile
-          pkgs
-          ;
 
       inherit (cfg) contents format name;
 
       fsType = "ext4";
       partitionTableType = if config.ec2.efi then "efi" else "legacy+gpt";
 
-        inherit (config.virtualisation) diskSize;
+      diskSize = cfg.sizeMB;
 
       postVM = ''
         extension=''${diskImage##*.}
@@ -190,8 +154,7 @@ in
           ' > $out/nix-support/image-info.json
       '';
     };
-    in
+  in if config.ec2.zfs.enable then zfsBuilder else extBuilder;
-    if config.ec2.zfs.enable then zfsBuilder else extBuilder;
 
   meta.maintainers = with lib.maintainers; [ arianvp ];
 }

nixos/maintainers/scripts/openstack/openstack-image-zfs.nix

@@ -1,37 +1,18 @@
 # nix-build '<nixpkgs/nixos>' -A config.system.build.openstackImage --arg configuration "{ imports = [ ./nixos/maintainers/scripts/openstack/openstack-image.nix ]; }"
 
-{
+{ config, lib, pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 let
   inherit (lib) mkOption types;
   copyChannel = true;
   cfg = config.openstackImage;
   imageBootMode = if config.openstack.efi then "uefi" else "legacy-bios";
-  virtualisationOptions = import ../../../modules/virtualisation/virtualisation-options.nix;
 in
 {
   imports = [
     ../../../modules/virtualisation/openstack-config.nix
-    virtualisationOptions.diskSize
-    (lib.mkRenamedOptionModuleWith {
-      sinceRelease = 2411;
-      from = [
-        "virtualisation"
-        "openstackImage"
-        "sizeMB"
-      ];
-      to = [
-        "virtualisation"
-        "diskSize"
-      ];
-    })
-
   ] ++ (lib.optional copyChannel ../../../modules/installer/cd-dvd/channel.nix);
 
+
   options.openstackImage = {
     name = mkOption {
       type = types.str;
@@ -41,15 +22,18 @@ in
 
     ramMB = mkOption {
       type = types.int;
-      default = (3 * 1024);
+      default = 1024;
       description = "RAM allocation for build VM";
     };
 
+    sizeMB = mkOption {
+      type = types.int;
+      default = 8192;
+      description = "The size in MB of the image";
+    };
+
     format = mkOption {
-      type = types.enum [
+      type = types.enum [ "raw" "qcow2" ];
-        "raw"
-        "qcow2"
-      ];
       default = "qcow2";
       description = "The image format to output";
     };
@@ -70,15 +54,13 @@ in
       };
     };
 
-    virtualisation.diskSize = lib.mkDefault (8 * 1024);
-    virtualisation.diskSizeAutoSupported = false;
-
     system.build.openstackImage = import ../../../lib/make-single-disk-zfs-image.nix {
       inherit lib config;
       inherit (cfg) contents format name;
       pkgs = import ../../../.. { inherit (pkgs) system; }; # ensure we use the regular qemu-kvm package
 
-      configFile = pkgs.writeText "configuration.nix" ''
+      configFile = pkgs.writeText "configuration.nix"
+        ''
           { modulesPath, ... }: {
             imports = [ "''${modulesPath}/virtualisation/openstack-config.nix" ];
             openstack.zfs.enable = true;
@@ -89,7 +71,7 @@ in
 
       bootSize = 1000;
       memSize = cfg.ramMB;
-      rootSize = config.virtualisation.diskSize;
+      rootSize = cfg.sizeMB;
       rootPoolProperties = {
         ashift = 12;
         autoexpand = "on";

nixos/modules/profiles/macos-builder.nix

@@ -1,9 +1,4 @@
-{
+{ config, lib, options, ... }:
-  config,
-  lib,
-  options,
-  ...
-}:
 
 let
   keysDirectory = "/var/keys";
@@ -20,19 +15,6 @@ in
   imports = [
     ../virtualisation/qemu-vm.nix
 
-    (lib.mkRenamedOptionModuleWith {
-      sinceRelease = 2411;
-      from = [
-        "virtualisation"
-        "darwin-builder"
-        "diskSize"
-      ];
-      to = [
-        "virtualisation"
-        "diskSize"
-      ];
-    })
-
     # Avoid a dependency on stateVersion
     {
       disabledModules = [
@@ -41,16 +23,17 @@ in
       ];
       # swraid's default depends on stateVersion
       config.boot.swraid.enable = false;
-      options.boot.isContainer = lib.mkOption {
+      options.boot.isContainer = lib.mkOption { default = false; internal = true; };
-        default = false;
-        internal = true;
-      };
     }
   ];
 
-  options.virtualisation.description = "The maximum disk space allocated to the runner in megabytes";
-
   options.virtualisation.darwin-builder = with lib; {
+    diskSize = mkOption {
+      default = 20 * 1024;
+      type = types.int;
+      example = 30720;
+      description = "The maximum disk space allocated to the runner in MB";
+    };
     memorySize = mkOption {
       default = 3 * 1024;
       type = types.int;
@@ -175,20 +158,13 @@ in
         script = hostPkgs.writeShellScriptBin "create-builder" (
           ''
             set -euo pipefail
-          ''
+          '' +
-          +
           # When running as non-interactively as part of a DarwinConfiguration the working directory
           # must be set to a writeable directory.
-            (
+        (if cfg.workingDirectory != "." then ''
-              if cfg.workingDirectory != "." then
-                ''
           ${hostPkgs.coreutils}/bin/mkdir --parent "${cfg.workingDirectory}"
           cd "${cfg.workingDirectory}"
-                ''
+        '' else "") + ''
-              else
-                ""
-            )
-          + ''
           KEYS="''${KEYS:-./keys}"
           ${hostPkgs.coreutils}/bin/mkdir --parent "''${KEYS}"
           PRIVATE_KEY="''${KEYS}/${user}_${keyType}"
@@ -201,8 +177,7 @@ in
             (set -x; sudo --reset-timestamp ${installCredentials} "''${KEYS}")
           fi
           KEYS="$(${hostPkgs.nix}/bin/nix-store --add "$KEYS")" ${lib.getExe config.system.build.vm}
-          ''
+        '');
-        );
 
       in
       script.overrideAttrs (old: {
@@ -248,16 +223,12 @@ in
     '';
 
     virtualisation = {
-      diskSize = lib.mkDefault (20 * 1024);
+      diskSize = cfg.diskSize;
 
       memorySize = cfg.memorySize;
 
       forwardPorts = [
-        {
+        { from = "host"; guest.port = 22; host.port = cfg.hostPort; }
-          from = "host";
-          guest.port = 22;
-          host.port = cfg.hostPort;
-        }
       ];
 
       # Disable graphics for the builder since users will likely want to run it

nixos/modules/virtualisation/azure-image.nix

@@ -1,34 +1,22 @@
-{
+{ config, lib, pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 with lib;
 let
   cfg = config.virtualisation.azureImage;
-  virtualisationOptions = import ./virtualisation-options.nix;
 in
 {
-  imports = [
+  imports = [ ./azure-common.nix ];
-    ./azure-common.nix
-    virtualisationOptions.diskSize
-    (lib.mkRenamedOptionModuleWith {
-      sinceRelease = 2411;
-      from = [
-        "virtualisation"
-        "azureImage"
-        "diskSize"
-      ];
-      to = [
-        "virtualisation"
-        "diskSize"
-      ];
-    })
-  ];
 
   options.virtualisation.azureImage = {
+    diskSize = mkOption {
+      type = with types; either (enum [ "auto" ]) int;
+      default = "auto";
+      example = 2048;
+      description = ''
+        Size of disk image. Unit is MB.
+      '';
+    };
+
     bootSize = mkOption {
       type = types.int;
       default = 256;
@@ -47,12 +35,7 @@ in
     };
 
     vmGeneration = mkOption {
-      type =
+      type = with types; enum [ "v1" "v2" ];
-        with types;
-        enum [
-          "v1"
-          "v2"
-        ];
       default = "v1";
       description = ''
         VM Generation to use.
@@ -74,8 +57,7 @@ in
       bootSize = "${toString cfg.bootSize}M";
       partitionTableType = if cfg.vmGeneration == "v2" then "efi" else "legacy";
 
-      inherit (cfg) contents;
+      inherit (cfg) diskSize contents;
-      inherit (config.virtualisation) diskSize;
       inherit config lib pkgs;
     };
   };

nixos/modules/virtualisation/digital-ocean-image.nix

@@ -1,35 +1,23 @@
-{
+{ config, lib, pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 with lib;
 let
   cfg = config.virtualisation.digitalOceanImage;
-  virtualisationOptions = import ./virtualisation-options.nix;
 in
 {
 
-  imports = [
+  imports = [ ./digital-ocean-config.nix ];
-    ./digital-ocean-config.nix
-    virtualisationOptions.diskSize
-    (lib.mkRenamedOptionModuleWith {
-      sinceRelease = 2411;
-      from = [
-        "virtualisation"
-        "digitialOceanImage"
-        "diskSize"
-      ];
-      to = [
-        "virtualisation"
-        "diskSize"
-      ];
-    })
-  ];
 
   options = {
+    virtualisation.digitalOceanImage.diskSize = mkOption {
+      type = with types; either (enum [ "auto" ]) int;
+      default = "auto";
+      example = 4096;
+      description = ''
+        Size of disk image. Unit is MB.
+      '';
+    };
+
     virtualisation.digitalOceanImage.configFile = mkOption {
       type = with types; nullOr path;
       default = null;
@@ -43,10 +31,7 @@ in
     };
 
     virtualisation.digitalOceanImage.compressionMethod = mkOption {
-      type = types.enum [
+      type = types.enum [ "gzip" "bzip2" ];
-        "gzip"
-        "bzip2"
-      ];
       default = "gzip";
       example = "bzip2";
       description = ''
@@ -59,35 +44,27 @@ in
 
   #### implementation
   config = {
+
     system.build.digitalOceanImage = import ../../lib/make-disk-image.nix {
       name = "digital-ocean-image";
       format = "qcow2";
-      postVM =
+      postVM = let
-        let
+        compress = {
-          compress =
-            {
           "gzip" = "${pkgs.gzip}/bin/gzip";
           "bzip2" = "${pkgs.bzip2}/bin/bzip2";
-            }
+        }.${cfg.compressionMethod};
-            .${cfg.compressionMethod};
+      in ''
-        in
-        ''
         ${compress} $diskImage
       '';
-      configFile =
+      configFile = if cfg.configFile == null
-        if cfg.configFile == null then
+        then config.virtualisation.digitalOcean.defaultConfigFile
-          config.virtualisation.digitalOcean.defaultConfigFile
+        else cfg.configFile;
-        else
+      inherit (cfg) diskSize;
-          cfg.configFile;
-      inherit (config.virtualisation) diskSize;
       inherit config lib pkgs;
     };
 
   };
 
-  meta.maintainers = with maintainers; [
+  meta.maintainers = with maintainers; [ arianvp eamsden ];
-    arianvp
-    eamsden
-  ];
 
 }

nixos/modules/virtualisation/google-compute-image.nix

@@ -1,9 +1,4 @@
-{
+{ config, lib, pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 with lib;
 let
@@ -16,28 +11,21 @@ let
       ];
     }
   '';
-  virtualisationOptions = import ./virtualisation-options.nix;
 in
 {
 
-  imports = [
+  imports = [ ./google-compute-config.nix ];
-    ./google-compute-config.nix
-    virtualisationOptions.diskSize
-    (lib.mkRenamedOptionModuleWith {
-      sinceRelease = 2411;
-      from = [
-        "virtualisation"
-        "googleComputeImage"
-        "diskSize"
-      ];
-      to = [
-        "virtualisation"
-        "diskSize"
-      ];
-    })
-  ];
 
   options = {
+    virtualisation.googleComputeImage.diskSize = mkOption {
+      type = with types; either (enum [ "auto" ]) int;
+      default = "auto";
+      example = 1536;
+      description = ''
+        Size of disk image. Unit is MB.
+      '';
+    };
+
     virtualisation.googleComputeImage.configFile = mkOption {
       type = with types; nullOr str;
       default = null;
@@ -76,13 +64,7 @@ in
     system.build.googleComputeImage = import ../../lib/make-disk-image.nix {
       name = "google-compute-image";
       postVM = ''
-        PATH=$PATH:${
+        PATH=$PATH:${with pkgs; lib.makeBinPath [ gnutar gzip ]}
-          with pkgs;
-          lib.makeBinPath [
-            gnutar
-            gzip
-          ]
-        }
         pushd $out
         mv $diskImage disk.raw
         tar -Sc disk.raw | gzip -${toString cfg.compressionLevel} > \
@@ -93,7 +75,7 @@ in
       format = "raw";
       configFile = if cfg.configFile == null then defaultConfigFile else cfg.configFile;
       partitionTableType = if cfg.efi then "efi" else "legacy";
-      inherit (config.virtualisation) diskSize;
+      inherit (cfg) diskSize;
       inherit config lib pkgs;
     };
 

nixos/modules/virtualisation/hyperv-image.nix

@@ -1,37 +1,21 @@
-{
+{ config, pkgs, lib, ... }:
-  config,
-  pkgs,
-  lib,
-  ...
-}:
 
 with lib;
 
 let
   cfg = config.hyperv;
-  virtualisationOptions = import ./virtualisation-options.nix;
-
-in
-{
-
-  imports = [
-    virtualisationOptions.diskSize
-    (lib.mkRenamedOptionModuleWith {
-      sinceRelease = 2411;
-      from = [
-        "virtualisation"
-        "hyperv"
-        "baseImageSize"
-      ];
-      to = [
-        "virtualisation"
-        "diskSize"
-      ];
-    })
-  ];
 
+in {
   options = {
     hyperv = {
+      baseImageSize = mkOption {
+        type = with types; either (enum [ "auto" ]) int;
+        default = "auto";
+        example = 2048;
+        description = ''
+          The size of the hyper-v base image in MiB.
+        '';
+      };
       vmDerivationName = mkOption {
         type = types.str;
         default = "nixos-hyperv-${config.system.nixos.label}-${pkgs.stdenv.hostPlatform.system}";
@@ -50,8 +34,6 @@ in
   };
 
   config = {
-    virtualisation.diskSize = lib.mkDefault (4 * 1024);
-
     system.build.hypervImage = import ../../lib/make-disk-image.nix {
       name = cfg.vmDerivationName;
       postVM = ''
@@ -59,7 +41,7 @@ in
         rm $diskImage
       '';
       format = "raw";
-      inherit (config.virtualisation) diskSize;
+      diskSize = cfg.baseImageSize;
       partitionTableType = "efi";
       inherit config lib pkgs;
     };

nixos/modules/virtualisation/linode-image.nix

@@ -1,9 +1,4 @@
-{
+{ config, lib, pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 with lib;
 let
@@ -15,27 +10,19 @@ let
       ];
     }
   '';
-  virtualisationOptions = import ./virtualisation-options.nix;
 in
 {
-  imports = [
+  imports = [ ./linode-config.nix ];
-    ./linode-config.nix
-    virtualisationOptions.diskSize
-    (lib.mkRenamedOptionModuleWith {
-      sinceRelease = 2411;
-      from = [
-        "virtualisation"
-        "linodeImage"
-        "diskSize"
-      ];
-      to = [
-        "virtualisation"
-        "diskSize"
-      ];
-    })
-  ];
 
   options = {
+    virtualisation.linodeImage.diskSize = mkOption {
+      type = with types; either (enum (singleton "auto")) ints.positive;
+      default = "auto";
+      example = 1536;
+      description = ''
+        Size of disk image in MB.
+      '';
+    };
 
     virtualisation.linodeImage.configFile = mkOption {
       type = with types; nullOr str;
@@ -70,7 +57,7 @@ in
       format = "raw";
       partitionTableType = "none";
       configFile = if cfg.configFile == null then defaultConfigFile else cfg.configFile;
-      inherit (config.virtualisation) diskSize;
+      inherit (cfg) diskSize;
       inherit config lib pkgs;
     };
   };

nixos/modules/virtualisation/oci-image.nix

@@ -1,9 +1,4 @@
-{
+{ config, lib, pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 let
   cfg = config.oci;
@@ -12,12 +7,9 @@ in
   imports = [ ./oci-common.nix ];
 
   config = {
-    virtualisation.diskSize = lib.mkDefault (8 * 1024);
-    virtualisation.diskSizeAutoSupported = false;
-
     system.build.OCIImage = import ../../lib/make-disk-image.nix {
       inherit config lib pkgs;
-      inherit (config.virtualisation) diskSize;
+      inherit (cfg) diskSize;
       name = "oci-image";
       configFile = ./oci-config-user.nix;
       format = "qcow2";
@@ -33,10 +25,7 @@ in
       after = [ "network-online.target" ];
       wants = [ "network-online.target" ];
 
-      path = [
+      path  = [ pkgs.coreutils pkgs.curl ];
-        pkgs.coreutils
-        pkgs.curl
-      ];
       script = ''
         mkdir -m 0700 -p /root/.ssh
         if [ -f /root/.ssh/authorized_keys ]; then

nixos/modules/virtualisation/oci-options.nix

@@ -1,27 +1,5 @@
+{ config, lib, pkgs, ... }:
 {
-  lib,
-  ...
-}:
-let
-  virtualisationOptions = import ./virtualisation-options.nix;
-in
-{
-  imports = [
-    virtualisationOptions.diskSize
-    (lib.mkRenamedOptionModuleWith {
-      sinceRelease = 2411;
-      from = [
-        "virtualisation"
-        "oci"
-        "diskSize"
-      ];
-      to = [
-        "virtualisation"
-        "diskSize"
-      ];
-    })
-  ];
-
   options = {
     oci = {
       efi = lib.mkOption {
@@ -31,6 +9,12 @@ in
           Whether the OCI instance is using EFI.
         '';
       };
+      diskSize = lib.mkOption {
+        type = lib.types.int;
+        default = 8192;
+        description = "Size of the disk image created in MB.";
+        example = "diskSize = 12 * 1024; # 12GiB";
+      };
     };
   };
 }

nixos/modules/virtualisation/proxmox-image.nix

@@ -1,31 +1,8 @@
-{
+{ config, pkgs, lib, ... }:
-  config,
-  pkgs,
-  lib,
-  ...
-}:
 
 with lib;
-let
-  virtualisationOptions = import ./virtualisation-options.nix;
-in
-{
-  imports = [
-    virtualisationOptions.diskSize
-    (lib.mkRenamedOptionModuleWith {
-      sinceRelease = 2411;
-      from = [
-        "virtualisation"
-        "proxmoxImage"
-        "diskSize"
-      ];
-      to = [
-        "virtualisation"
-        "diskSize"
-      ];
-    })
-  ];
 
+{
   options.proxmox = {
     qemuConf = {
       # essential configs
@@ -77,10 +54,7 @@ in
         '';
       };
       bios = mkOption {
-        type = types.enum [
+        type = types.enum [ "seabios" "ovmf" ];
-          "seabios"
-          "ovmf"
-        ];
         default = "seabios";
         description = ''
           Select BIOS implementation (seabios = Legacy BIOS, ovmf = UEFI).
@@ -113,6 +87,16 @@ in
           either "efi" or "hybrid".
         '';
       };
+      diskSize = mkOption {
+        type = types.str;
+        default = "auto";
+        example = "20480";
+        description = ''
+          The size of the disk, in megabytes.
+          if "auto" size is calculated based on the contents copied to it and
+          additionalSpace is taken into account.
+        '';
+      };
       net0 = mkOption {
         type = types.commas;
         default = "virtio=00:00:00:00:00:00,bridge=vmbr0,firewall=1";
@@ -140,13 +124,8 @@ in
       };
     };
     qemuExtraConf = mkOption {
-      type =
+      type = with types; attrsOf (oneOf [ str int ]);
-        with types;
+      default = {};
-        attrsOf (oneOf [
-          str
-          int
-        ]);
-      default = { };
       example = literalExpression ''
         {
           cpu = "host";
@@ -158,12 +137,7 @@ in
       '';
     };
     partitionTableType = mkOption {
-      type = types.enum [
+      type = types.enum [ "efi" "hybrid" "legacy" "legacy+gpt" ];
-        "efi"
-        "hybrid"
-        "legacy"
-        "legacy+gpt"
-      ];
       description = ''
         Partition table type to use. See make-disk-image.nix partitionTableType for details.
         Defaults to 'legacy' for 'proxmox.qemuConf.bios="seabios"' (default), other bios values defaults to 'efi'.
@@ -211,30 +185,23 @@ in
     };
   };
 
-  config =
+  config = let
-    let
     cfg = config.proxmox;
     cfgLine = name: value: ''
       ${name}: ${builtins.toString value}
     '';
     virtio0Storage = builtins.head (builtins.split ":" cfg.qemuConf.virtio0);
-      cfgFile =
+    cfgFile = fileName: properties: pkgs.writeTextDir fileName ''
-        fileName: properties:
-        pkgs.writeTextDir fileName ''
       # generated by NixOS
       ${lib.concatStrings (lib.mapAttrsToList cfgLine properties)}
       #qmdump#map:virtio0:drive-virtio0:${virtio0Storage}:raw:
     '';
     inherit (cfg) partitionTableType;
     supportEfi = partitionTableType == "efi" || partitionTableType == "hybrid";
-      supportBios =
+    supportBios = partitionTableType == "legacy" || partitionTableType == "hybrid" || partitionTableType == "legacy+gpt";
-        partitionTableType == "legacy"
-        || partitionTableType == "hybrid"
-        || partitionTableType == "legacy+gpt";
     hasBootPartition = partitionTableType == "efi" || partitionTableType == "hybrid";
     hasNoFsPartition = partitionTableType == "hybrid" || partitionTableType == "legacy+gpt";
-    in
+  in {
-    {
     assertions = [
       {
         assertion = config.boot.loader.systemd-boot.enable -> config.proxmox.qemuConf.bios == "ovmf";
@@ -256,11 +223,9 @@ in
     system.build.VMA = import ../../lib/make-disk-image.nix {
       name = "proxmox-${cfg.filenameSuffix}";
       inherit (cfg) partitionTableType;
-        postVM =
+      postVM = let
-          let
         # Build qemu with PVE's patch that adds support for the VMA format
-            vma =
+        vma = (pkgs.qemu_kvm.override {
-              (pkgs.qemu_kvm.override {
           alsaSupport = false;
           pulseSupport = false;
           sdlSupport = false;
@@ -275,8 +240,7 @@ in
           numaSupport = false;
           seccompSupport = false;
           guestAgentSupport = false;
-              }).overrideAttrs
+        }).overrideAttrs ( super: rec {
-                (super: rec {
           # Check https://github.com/proxmox/pve-qemu/tree/master for the version
           # of qemu and patch to use
           version = "9.0.0";
@@ -286,14 +250,12 @@ in
           };
           patches = [
             # Proxmox' VMA tool is published as a particular patch upon QEMU
-                    "${
+            "${pkgs.fetchFromGitHub {
-                      pkgs.fetchFromGitHub {
               owner = "proxmox";
               repo = "pve-qemu";
               rev = "14afbdd55f04d250bd679ca1ad55d3f47cd9d4c8";
               hash = "sha256-lSJQA5SHIHfxJvMLIID2drv2H43crTPMNIlIT37w9Nc=";
-                      }
+            }}/debian/patches/pve/0027-PVE-Backup-add-vma-backup-format-code.patch"
-                    }/debian/patches/pve/0027-PVE-Backup-add-vma-backup-format-code.patch"
           ];
 
           buildInputs = super.buildInputs ++ [ pkgs.libuuid ];
@@ -303,9 +265,7 @@ in
       in
       ''
         ${vma}/bin/vma create "vzdump-qemu-${cfg.filenameSuffix}.vma" \
-              -c ${
+          -c ${cfgFile "qemu-server.conf" (cfg.qemuConf // cfg.qemuExtraConf)}/qemu-server.conf drive-virtio0=$diskImage
-                cfgFile "qemu-server.conf" (cfg.qemuConf // cfg.qemuExtraConf)
-              }/qemu-server.conf drive-virtio0=$diskImage
         rm $diskImage
         ${pkgs.zstd}/bin/zstd "vzdump-qemu-${cfg.filenameSuffix}.vma"
         mv "vzdump-qemu-${cfg.filenameSuffix}.vma.zst" $out/
@@ -313,8 +273,7 @@ in
         mkdir -p $out/nix-support
         echo "file vma $out/vzdump-qemu-${cfg.filenameSuffix}.vma.zst" > $out/nix-support/hydra-build-products
       '';
-        inherit (cfg.qemuConf) additionalSpace bootSize;
+      inherit (cfg.qemuConf) additionalSpace diskSize bootSize;
-        inherit (config.virtualisation) diskSize;
       format = "raw";
       inherit config lib pkgs;
     };
@@ -323,25 +282,19 @@ in
       growPartition = true;
       kernelParams = [ "console=ttyS0" ];
       loader.grub = {
-          device = lib.mkDefault (
+        device = lib.mkDefault (if (hasNoFsPartition || supportBios) then
-            if (hasNoFsPartition || supportBios) then
           # Even if there is a separate no-fs partition ("/dev/disk/by-partlabel/no-fs" i.e. "/dev/vda2"),
           # which will be used the bootloader, do not set it as loader.grub.device.
           # GRUB installation fails, unless the whole disk is selected.
           "/dev/vda"
         else
-              "nodev"
+          "nodev");
-          );
         efiSupport = lib.mkDefault supportEfi;
         efiInstallAsRemovable = lib.mkDefault supportEfi;
       };
 
       loader.timeout = 0;
-        initrd.availableKernelModules = [
+      initrd.availableKernelModules = [ "uas" "virtio_blk" "virtio_pci" ];
-          "uas"
-          "virtio_blk"
-          "virtio_pci"
-        ];
     };
 
     fileSystems."/" = {

nixos/modules/virtualisation/virtualbox-image.nix

@@ -1,37 +1,23 @@
-{
+{ config, lib, pkgs, ... }:
-  config,
-  lib,
-  pkgs,
-  ...
-}:
 
 with lib;
 
 let
 
   cfg = config.virtualbox;
-  virtualisationOptions = import ./virtualisation-options.nix;
 
-in
+in {
-{
-  imports = [
-    virtualisationOptions.diskSize
-    (lib.mkRenamedOptionModuleWith {
-      sinceRelease = 2411;
-      from = [
-        "virtualisation"
-        "virtualbox"
-        "baseImageSize"
-      ];
-      to = [
-        "virtualisation"
-        "diskSize"
-      ];
-    })
-  ];
 
   options = {
     virtualbox = {
+      baseImageSize = mkOption {
+        type = with types; either (enum [ "auto" ]) int;
+        default = "auto";
+        example = 50 * 1024;
+        description = ''
+          The size of the VirtualBox base image in MiB.
+        '';
+      };
       baseImageFreeSpace = mkOption {
         type = with types; int;
         default = 30 * 1024;
@@ -68,14 +54,7 @@ in
         '';
       };
       params = mkOption {
-        type =
+        type = with types; attrsOf (oneOf [ str int bool (listOf str) ]);
-          with types;
-          attrsOf (oneOf [
-            str
-            int
-            bool
-            (listOf str)
-          ]);
         example = {
           audio = "alsa";
           rtcuseutc = "on";
@@ -88,21 +67,11 @@ in
         '';
       };
       exportParams = mkOption {
-        type =
+        type = with types; listOf (oneOf [ str int bool (listOf str) ]);
-          with types;
-          listOf (oneOf [
-            str
-            int
-            bool
-            (listOf str)
-          ]);
         example = [
-          "--vsys"
+          "--vsys" "0" "--vendor" "ACME Inc."
-          "0"
-          "--vendor"
-          "ACME Inc."
         ];
-        default = [ ];
+        default = [];
         description = ''
           Parameters passed to the Virtualbox export command.
 
@@ -120,8 +89,7 @@ in
           mountPoint = "/home/demo/storage";
           size = 100 * 1024;
         };
-        type = types.nullOr (
+        type = types.nullOr (types.submodule {
-          types.submodule {
           options = {
             size = mkOption {
               type = types.int;
@@ -137,8 +105,7 @@ in
               description = "Path where to mount this disk.";
             };
           };
-          }
+        });
-        );
       };
       postExportCommands = mkOption {
         type = types.lines;
@@ -158,14 +125,7 @@ in
         '';
       };
       storageController = mkOption {
-        type =
+        type = with types; attrsOf (oneOf [ str int bool (listOf str) ]);
-          with types;
-          attrsOf (oneOf [
-            str
-            int
-            bool
-            (listOf str)
-          ]);
         example = {
           name = "SCSI";
           add = "scsi";
@@ -192,8 +152,6 @@ in
 
   config = {
 
-    virtualisation.diskSize = lib.mkDefault (50 * 1024);
-
     virtualbox.params = mkMerge [
       (mapAttrs (name: mkDefault) {
         acpi = "on";
@@ -217,10 +175,11 @@ in
 
       inherit pkgs lib config;
       partitionTableType = "legacy";
-      inherit (config.virtualisation) diskSize;
+      diskSize = cfg.baseImageSize;
       additionalSpace = "${toString cfg.baseImageFreeSpace}M";
 
-      postVM = ''
+      postVM =
+        ''
           export HOME=$PWD
           export PATH=${pkgs.virtualbox}/bin:$PATH
 
@@ -269,15 +228,13 @@ in
         '';
     };
 
-    fileSystems =
+    fileSystems = {
-      {
       "/" = {
         device = "/dev/disk/by-label/nixos";
         autoResize = true;
         fsType = "ext4";
       };
-      }
+    } // (lib.optionalAttrs (cfg.extraDisk != null) {
-      // (lib.optionalAttrs (cfg.extraDisk != null) {
       ${cfg.extraDisk.mountPoint} = {
         device = "/dev/disk/by-label/" + cfg.extraDisk.label;
         autoResize = true;
@@ -288,12 +245,10 @@ in
     boot.growPartition = true;
     boot.loader.grub.device = "/dev/sda";
 
-    swapDevices = [
+    swapDevices = [{
-      {
       device = "/var/swap";
       size = 2048;
-      }
+    }];
-    ];
 
     virtualisation.virtualbox.guest.enable = true;
 

nixos/modules/virtualisation/virtualisation-options.nix

@@ -1,60 +0,0 @@
-# This modules declares shared options for virtual machines,
-# containers and anything else in `virtualisation`.
-#
-# This is useful to declare e.g. defaults for
-# `virtualisation.diskSize` once, while building multiple
-# different image formats of a NixOS configuration.
-#
-# Additional options can be migrated over time from
-# `modules/virtualisation/qemu-vm.nix` and others.
-# Please keep defaults and descriptions here generic
-# and independent of i.e. hypervisor-specific notes
-# and defaults where.
-# Those can be added in the consuming modules where needed.
-# needed.
-let
-  _file = ./virtualisation-options.nix;
-  key = _file;
-in
-{
-  diskSize =
-    { lib, config, ... }:
-    let
-      t = lib.types;
-    in
-    {
-      inherit _file key;
-
-      options = {
-        virtualisation.diskSizeAutoSupported = lib.mkOption {
-          type = t.bool;
-          default = true;
-          description = ''
-            Whether the current image builder or vm runner supports `virtualisation.diskSize = "auto".`
-          '';
-          internal = true;
-        };
-
-        virtualisation.diskSize = lib.mkOption {
-          type = t.either (t.enum [ "auto" ]) t.ints.positive;
-          default = "auto";
-          description = ''
-            The disk size in megabytes of the virtual machine.
-          '';
-        };
-      };
-
-      config =
-        let
-          inherit (config.virtualisation) diskSize diskSizeAutoSupported;
-        in
-        {
-          assertions = [
-            {
-              assertion = diskSize != "auto" || diskSizeAutoSupported;
-              message = "Setting virtualisation.diskSize to `auto` is not supported by the current image build or vm runner; use an explicit size.";
-            }
-          ];
-        };
-    };
-}

nixos/release.nix

@@ -312,7 +312,7 @@ in rec {
         [ configuration
           versionModule
           ./maintainers/scripts/ec2/amazon-image.nix
-          ({ ... }: { amazonImage.virtualisation.diskSize = "auto"; })
+          ({ ... }: { amazonImage.sizeMB = "auto"; })
         ];
     }).config.system.build.amazonImage)