talexander/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Releases Activity

hoarder: don't set phases, don't overwrite fixupPhase, minor cleanups

Browse Source 
Setting phases should only done by lower level functions or wrappers
around mkDerivation, not packages.
Overwritting fixupPhase can break some things similar to patchPhase. It
should generally not be overwritten in packages.
This commit is contained in:
Sandro Jäckel 2025-04-11 01:14:42 +02:00
parent 6514427d4c
commit 89cbfe02ce
No known key found for this signature in database
GPG Key ID: 3AF5A43A3EECC2E5
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pkgs/by-name/ho/hoarder/package.nix
View File

@ -46,14 +46,10 @@ stdenv.mkDerivation (finalAttrs: {
# We need to pass the patched source code, so pnpm sees the patched version
src = stdenv.mkDerivation {
name = "${finalAttrs.pname}-patched-source";
phases = [
"unpackPhase"
"patchPhase"
"installPhase"
];
src = finalAttrs.src;
patches = finalAttrs.patches;
installPhase = "cp -pr --reflink=auto -- . $out";
inherit (finalAttrs) src patches;
installPhase = ''
cp -pr --reflink=auto -- . $out
'';
};
hash = "sha256-FzQPBIwe7OQ1KHaMtWaFe+RI+pXko5Ly11/jOmYSuFA=";
@ -121,16 +117,12 @@ stdenv.mkDerivation (finalAttrs: {
runHook postInstall
'';
fixupPhase = ''
runHook preFixup
postFixup = ''
# Remove large dependencies that are not necessary during runtime
rm -rf $out/lib/hoarder/node_modules/{@next,next,@swc,react-native,monaco-editor,faker,@typescript-eslint,@microsoft,@typescript-eslint,pdfjs-dist}
# Remove broken symlinks
find $out -type l ! -exec test -e {} \; -delete
runHook postFixup
'';
meta = {