5645cd22d4
Closes #376820 The issue with providing `moduleMakeFlags` via `passthru` of the kernel package is that when this package gets overriden[1], the `moduleMakeFlags` list still references the kernel without the overrides. This broke e.g. kernel modules of linux-rpi4 which can be reproduced with nix-build --argstr system aarch64-linux -A linuxKernel.packages.linux_rpi4.zfs_2_3 This used to break with Error: modDirVersion 6.6.51 specified in the Nix expression is wrong, it should be: 6.6.51-v8 since KBUILD_OUTPUT referenced the kernel without the changes from `overrideDerivation` that also changes the `modDirVersion`. The new approach is to add the build flags right into `linuxKernel.packages.linux_X_Y`: that way we don't need any hacks to update `moduleMakeFlags` when the derivation with the passthru gets overridden. By using the fixpoint of the package-set, the `kernelModuleMakeFlags` list is correctly updated. E.g. given with import ./. {}; linuxKernel.packages.linux_6_6.extend (self: super: { kernel = super.kernel.overrideAttrs (_: { name = "linux-snens"; }); }) the `makeFlags` is correctly updated: $ nix-instantiate snenskek.nix -A zfs_2_3.makeFlags --eval --strict [ "ARCH=x86_64" "CROSS_COMPILE=" "KBUILD_OUTPUT=/nix/store/gsp68549k1aqbwxwczpgw67w5jjn4shw-linux-snens-dev/lib/modules/6.6.74/build" ] [1] E.g. `linux-rpi4`.
59 lines
1.6 KiB
Nix
59 lines
1.6 KiB
Nix
{
|
|
lib,
|
|
stdenv,
|
|
fetchFromGitLab,
|
|
kernel,
|
|
kernelModuleMakeFlags,
|
|
fetchpatch,
|
|
}:
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "ddcci-driver";
|
|
version = "0.4.5-unstable-2024-09-26";
|
|
name = "${pname}-${kernel.version}-${version}";
|
|
|
|
src = fetchFromGitLab {
|
|
owner = "${pname}-linux";
|
|
repo = "${pname}-linux";
|
|
rev = "0233e1ee5eddb4b8a706464f3097bad5620b65f4";
|
|
hash = "sha256-Osvojt8UE+cenOuMoSY+T+sODTAAKkvY/XmBa5bQX88=";
|
|
};
|
|
|
|
patches = [
|
|
# See https://gitlab.com/ddcci-driver-linux/ddcci-driver-linux/-/merge_requests/17
|
|
(fetchpatch {
|
|
url = "https://gitlab.com/ddcci-driver-linux/ddcci-driver-linux/-/commit/e0605c9cdff7bf3fe9587434614473ba8b7e5f63.patch";
|
|
hash = "sha256-sTq03HtWQBd7Wy4o1XbdmMjXQE2dG+1jajx4HtwBHjM=";
|
|
})
|
|
];
|
|
|
|
hardeningDisable = [ "pic" ];
|
|
|
|
nativeBuildInputs = kernel.moduleBuildDependencies;
|
|
|
|
prePatch = ''
|
|
substituteInPlace ./ddcci/Makefile \
|
|
--replace '"$(src)"' '$(PWD)' \
|
|
--replace depmod \#
|
|
substituteInPlace ./ddcci-backlight/Makefile \
|
|
--replace '"$(src)"' '$(PWD)' \
|
|
--replace depmod \#
|
|
'';
|
|
|
|
makeFlags = kernelModuleMakeFlags ++ [
|
|
"KDIR=${kernel.dev}/lib/modules/${kernel.modDirVersion}/build"
|
|
"KVER=${kernel.modDirVersion}"
|
|
"KERNEL_MODLIB=$(out)/lib/modules/${kernel.modDirVersion}"
|
|
"INCLUDEDIR=$(out)/include"
|
|
];
|
|
|
|
meta = with lib; {
|
|
description = "Kernel module driver for DDC/CI monitors";
|
|
homepage = "https://gitlab.com/ddcci-driver-linux/ddcci-driver-linux";
|
|
license = licenses.gpl2Plus;
|
|
maintainers = with maintainers; [ kiike ];
|
|
platforms = platforms.linux;
|
|
broken = kernel.kernelOlder "5.1";
|
|
};
|
|
}
|