
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
46 lines
1.0 KiB
Nix
46 lines
1.0 KiB
Nix
{
|
|
stdenv,
|
|
lib,
|
|
fetchFromGitHub,
|
|
buildPerlPackage,
|
|
shortenPerlShebang,
|
|
LWP,
|
|
LWPProtocolHttps,
|
|
DataDump,
|
|
JSON,
|
|
gitUpdater,
|
|
}:
|
|
|
|
buildPerlPackage rec {
|
|
pname = "WWW-YoutubeViewer";
|
|
version = "3.11.2";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "trizen";
|
|
repo = "youtube-viewer";
|
|
rev = version;
|
|
sha256 = "9Z4fv2B0AnwtYsp7h9phnRMmHtBOMObIJvK8DmKQRxs=";
|
|
};
|
|
|
|
nativeBuildInputs = lib.optional stdenv.hostPlatform.isDarwin shortenPerlShebang;
|
|
propagatedBuildInputs = [
|
|
LWP
|
|
LWPProtocolHttps
|
|
DataDump
|
|
JSON
|
|
];
|
|
postInstall = lib.optionalString stdenv.hostPlatform.isDarwin ''
|
|
shortenPerlShebang $out/bin/youtube-viewer
|
|
'';
|
|
|
|
passthru.updateScript = gitUpdater { };
|
|
|
|
meta = with lib; {
|
|
description = "Lightweight application for searching and streaming videos from YouTube";
|
|
homepage = "https://github.com/trizen/youtube-viewer";
|
|
license = with licenses; [ artistic2 ];
|
|
maintainers = with maintainers; [ woffs ];
|
|
mainProgram = "youtube-viewer";
|
|
};
|
|
}
|