5645cd22d4
Closes #376820 The issue with providing `moduleMakeFlags` via `passthru` of the kernel package is that when this package gets overriden[1], the `moduleMakeFlags` list still references the kernel without the overrides. This broke e.g. kernel modules of linux-rpi4 which can be reproduced with nix-build --argstr system aarch64-linux -A linuxKernel.packages.linux_rpi4.zfs_2_3 This used to break with Error: modDirVersion 6.6.51 specified in the Nix expression is wrong, it should be: 6.6.51-v8 since KBUILD_OUTPUT referenced the kernel without the changes from `overrideDerivation` that also changes the `modDirVersion`. The new approach is to add the build flags right into `linuxKernel.packages.linux_X_Y`: that way we don't need any hacks to update `moduleMakeFlags` when the derivation with the passthru gets overridden. By using the fixpoint of the package-set, the `kernelModuleMakeFlags` list is correctly updated. E.g. given with import ./. {}; linuxKernel.packages.linux_6_6.extend (self: super: { kernel = super.kernel.overrideAttrs (_: { name = "linux-snens"; }); }) the `makeFlags` is correctly updated: $ nix-instantiate snenskek.nix -A zfs_2_3.makeFlags --eval --strict [ "ARCH=x86_64" "CROSS_COMPILE=" "KBUILD_OUTPUT=/nix/store/gsp68549k1aqbwxwczpgw67w5jjn4shw-linux-snens-dev/lib/modules/6.6.74/build" ] [1] E.g. `linux-rpi4`.
42 lines
1.2 KiB
Nix
42 lines
1.2 KiB
Nix
{
|
|
lib,
|
|
stdenv,
|
|
kernel,
|
|
kernelModuleMakeFlags,
|
|
bash,
|
|
lenovo-legion,
|
|
}:
|
|
|
|
stdenv.mkDerivation {
|
|
pname = "lenovo-legion-module";
|
|
inherit (lenovo-legion) version src;
|
|
|
|
sourceRoot = "${lenovo-legion.src.name}/kernel_module";
|
|
|
|
hardeningDisable = [ "pic" ];
|
|
|
|
preConfigure = ''
|
|
sed -i -e '/depmod/d' ./Makefile
|
|
'';
|
|
|
|
makeFlags = kernelModuleMakeFlags ++ [
|
|
"SHELL=bash"
|
|
"KERNELVERSION=${kernel.modDirVersion}"
|
|
"KSRC=${kernel.dev}/lib/modules/${kernel.modDirVersion}/build"
|
|
"INSTALLDIR=${placeholder "out"}/lib/modules/${kernel.modDirVersion}/kernel/drivers/platform/x86"
|
|
"MODDESTDIR=${placeholder "out"}/lib/modules/${kernel.modDirVersion}/kernel/drivers/platform/x86"
|
|
"DKMSDIR=${placeholder "out"}/lib/modules/${kernel.modDirVersion}/misc"
|
|
];
|
|
|
|
nativeBuildInputs = kernel.moduleBuildDependencies;
|
|
|
|
meta = {
|
|
description = "Linux kernel module for controlling fan and power in Lenovo Legion laptops";
|
|
homepage = "https://github.com/johnfanv2/LenovoLegionLinux";
|
|
license = lib.licenses.gpl2Only;
|
|
platforms = lib.platforms.linux;
|
|
maintainers = [ lib.maintainers.ulrikstrid ];
|
|
broken = kernel.kernelOlder "5.15";
|
|
};
|
|
}
|