Pratham Patel 1c19cb81e7
nixos/geoclue2: add option to manage whitelisted agents
The geoclue2 module recommends that the guest agent be disabled when the
desktop environment provides their own geoclue2 agent. But when a
desktop environment uses the demo agent directly, like COSMIC does, the
demo agent must be whitelisted. But disabling the demo agent also
removes it from the whitelisted agents.

This commit adds an option which holds a list of all whitelisted
geoclue2 agents. It allows for consumers like COSMIC to have the demo
agent disabled but still whitelisted for such use cases.
2025-06-15 12:01:51 +05:30

380 lines
10 KiB
Nix

# GeoClue 2 daemon.
{
config,
lib,
pkgs,
...
}:
let
cfg = config.services.geoclue2;
appConfigModule = lib.types.submodule (
{ name, ... }:
{
options = {
desktopID = lib.mkOption {
type = lib.types.str;
description = "Desktop ID of the application.";
};
isAllowed = lib.mkOption {
type = lib.types.bool;
description = ''
Whether the application will be allowed access to location information.
'';
};
isSystem = lib.mkOption {
type = lib.types.bool;
description = ''
Whether the application is a system component or not.
'';
};
users = lib.mkOption {
type = lib.types.listOf lib.types.str;
default = [ ];
description = ''
List of UIDs of all users for which this application is allowed location
info access, Defaults to an empty string to allow it for all users.
'';
};
};
config.desktopID = lib.mkDefault name;
}
);
appConfigToINICompatible =
_:
{
desktopID,
isAllowed,
isSystem,
users,
...
}:
{
name = desktopID;
value = {
allowed = isAllowed;
system = isSystem;
users = lib.concatStringsSep ";" users;
};
};
in
{
###### interface
options = {
services.geoclue2 = {
enable = lib.mkOption {
type = lib.types.bool;
default = false;
description = ''
Whether to enable GeoClue 2 daemon, a DBus service
that provides location information for accessing.
'';
};
whitelistedAgents = lib.mkOption {
type = lib.types.listOf lib.types.str;
default = [
"gnome-shell"
"io.elementary.desktop.agent-geoclue2"
];
description = ''
Desktop IDs (without the .desktop extension) of whitelisted agents.
'';
};
enableDemoAgent = lib.mkOption {
type = lib.types.bool;
default = true;
description = ''
Whether to use the GeoClue demo agent. This should be
overridden by desktop environments that provide their own
agent.
'';
};
enableNmea = lib.mkOption {
type = lib.types.bool;
default = true;
description = ''
Whether to fetch location from NMEA sources on local network.
'';
};
enable3G = lib.mkOption {
type = lib.types.bool;
default = true;
description = ''
Whether to enable 3G source.
'';
};
enableCDMA = lib.mkOption {
type = lib.types.bool;
default = true;
description = ''
Whether to enable CDMA source.
'';
};
enableModemGPS = lib.mkOption {
type = lib.types.bool;
default = true;
description = ''
Whether to enable Modem-GPS source.
'';
};
enableWifi = lib.mkOption {
type = lib.types.bool;
default = true;
description = ''
Whether to enable WiFi source.
'';
};
enableStatic = lib.mkOption {
type = lib.types.bool;
default = false;
description = ''
Whether to enable the static source. This source defines a fixed
location using the `staticLatitude`, `staticLongitude`,
`staticAltitude`, and `staticAccuracy` options.
Setting `enableStatic` to true will disable all other sources, to
prevent conflicts. Use `lib.mkForce true` when enabling other sources
if for some reason you want to override this.
'';
};
staticLatitude = lib.mkOption {
type = lib.types.numbers.between (-90) 90;
description = ''
Latitude to use for the static source. Defaults to `location.latitude`.
'';
};
staticLongitude = lib.mkOption {
type = lib.types.numbers.between (-180) 180;
description = ''
Longitude to use for the static source. Defaults to `location.longitude`.
'';
};
staticAltitude = lib.mkOption {
type = lib.types.number;
description = ''
Altitude in meters to use for the static source.
'';
};
staticAccuracy = lib.mkOption {
type = lib.types.numbers.positive;
description = ''
Accuracy radius in meters to use for the static source.
'';
};
geoProviderUrl = lib.mkOption {
type = lib.types.str;
default = "https://api.beacondb.net/v1/geolocate";
example = "https://www.googleapis.com/geolocation/v1/geolocate?key=YOUR_KEY";
description = ''
The url to the wifi GeoLocation Service.
'';
};
package = lib.mkOption {
type = lib.types.package;
default = pkgs.geoclue2;
defaultText = lib.literalExpression "pkgs.geoclue2";
apply =
pkg:
pkg.override {
# the demo agent isn't built by default, but we need it here
withDemoAgent = cfg.enableDemoAgent;
};
description = "The geoclue2 package to use";
};
submitData = lib.mkOption {
type = lib.types.bool;
default = false;
description = ''
Whether to submit data to a GeoLocation Service.
'';
};
submissionUrl = lib.mkOption {
type = lib.types.str;
default = "https://api.beacondb.net/v2/geosubmit";
description = ''
The url to submit data to a GeoLocation Service.
'';
};
submissionNick = lib.mkOption {
type = lib.types.str;
default = "geoclue";
description = ''
A nickname to submit network data with.
Must be 2-32 characters long.
'';
};
appConfig = lib.mkOption {
type = lib.types.attrsOf appConfigModule;
default = { };
example = lib.literalExpression ''
"com.github.app" = {
isAllowed = true;
isSystem = true;
users = [ "300" ];
};
'';
description = ''
Specify extra settings per application.
'';
};
};
};
###### implementation
config = lib.mkIf cfg.enable {
environment.systemPackages = [ cfg.package ];
services.dbus.packages = [ cfg.package ];
systemd.packages = [ cfg.package ];
# we cannot use DynamicUser as we need the the geoclue user to exist for the
# dbus policy to work
users = {
users.geoclue = {
isSystemUser = true;
home = "/var/lib/geoclue";
group = "geoclue";
description = "Geoinformation service";
};
groups.geoclue = { };
};
services.geoclue2 = {
enable3G = lib.mkIf cfg.enableStatic false;
enableCDMA = lib.mkIf cfg.enableStatic false;
enableModemGPS = lib.mkIf cfg.enableStatic false;
enableNmea = lib.mkIf cfg.enableStatic false;
enableWifi = lib.mkIf cfg.enableStatic false;
staticLatitude = lib.mkDefault config.location.latitude;
staticLongitude = lib.mkDefault config.location.longitude;
};
systemd.services.geoclue = {
wants = lib.optionals cfg.enableWifi [ "network-online.target" ];
after = lib.optionals cfg.enableWifi [ "network-online.target" ];
# restart geoclue service when the configuration changes
restartTriggers = [
config.environment.etc."geoclue/geoclue.conf".source
];
serviceConfig.StateDirectory = "geoclue";
};
# this needs to run as a user service, since it's associated with the
# user who is making the requests
systemd.user.services = lib.mkIf cfg.enableDemoAgent {
geoclue-agent = {
description = "Geoclue agent";
# this should really be `partOf = [ "geoclue.service" ]`, but
# we can't be part of a system service, and the agent should
# be okay with the main service coming and going
wantedBy = [ "default.target" ];
wants = lib.optionals cfg.enableWifi [ "network-online.target" ];
after = lib.optionals cfg.enableWifi [ "network-online.target" ];
unitConfig.ConditionUser = "!@system";
serviceConfig = {
Type = "exec";
ExecStart = "${cfg.package}/libexec/geoclue-2.0/demos/agent";
Restart = "on-failure";
PrivateTmp = true;
};
};
};
services.geoclue2.appConfig.epiphany = {
isAllowed = true;
isSystem = false;
};
services.geoclue2.appConfig.firefox = {
isAllowed = true;
isSystem = false;
};
environment.etc."geoclue/geoclue.conf".text = lib.generators.toINI { } (
{
agent = {
whitelist = lib.concatStringsSep ";" (
lib.lists.unique (
cfg.whitelistedAgents
++ lib.optionals config.services.geoclue2.enableDemoAgent [ "geoclue-demo-agent" ]
)
);
};
network-nmea = {
enable = cfg.enableNmea;
};
"3g" = {
enable = cfg.enable3G;
};
cdma = {
enable = cfg.enableCDMA;
};
modem-gps = {
enable = cfg.enableModemGPS;
};
wifi =
{
enable = cfg.enableWifi;
}
// lib.optionalAttrs cfg.enableWifi {
url = cfg.geoProviderUrl;
submit-data = lib.boolToString cfg.submitData;
submission-url = cfg.submissionUrl;
submission-nick = cfg.submissionNick;
};
static-source = {
enable = cfg.enableStatic;
};
}
// lib.mapAttrs' appConfigToINICompatible cfg.appConfig
);
environment.etc.geolocation = lib.mkIf cfg.enableStatic {
mode = "0440";
group = "geoclue";
text = ''
${toString cfg.staticLatitude}
${toString cfg.staticLongitude}
${toString cfg.staticAltitude}
${toString cfg.staticAccuracy}
'';
};
};
meta = with lib; {
maintainers = with maintainers; [ ] ++ teams.pantheon.members;
};
}