1
0
mirror of https://git.savannah.gnu.org/git/emacs.git synced 2024-12-11 09:20:51 +00:00
Commit Graph

136777 Commits

Author SHA1 Message Date
Lars Ingebrigtsen
aa41909c85 Suppress interactive-only warnings in epa*.el
* lisp/epa-mail.el (epa-mail-decrypt, epa-mail-verify)
(epa-mail-sign, epa-mail-encrypt): Ditto.

* lisp/epa.el (epa-verify-cleartext-in-region): Suppress warnings
about calling interactive-only functions, because these are
interactive-only thin wrappers around those functions.
2019-06-12 16:17:25 +02:00
Lars Ingebrigtsen
f9b61ba72e ehelp.el: Suppress warning
* lisp/ehelp.el (electric-help-execute-extended): Suppress warning
about `execute-extended-command' only being interactive, because
we're still using it interactively, but via a wrapper.
2019-06-12 16:15:30 +02:00
Lars Ingebrigtsen
f2071b6de4 Add the new macro with-suppressed-warnings
* lisp/emacs-lisp/byte-run.el (with-suppressed-warnings): New macro.

* doc/lispref/compile.texi (Compiler Errors): Document
with-suppressed-warnings and deemphasise with-no-warnings
slightly.

* lisp/emacs-lisp/bytecomp.el (byte-compile--suppressed-warnings):
New internal variable.
(byte-compile-warning-enabled-p): Heed
byte-compile--suppressed-warnings, bound via with-suppressed-warnings.
(byte-compile-initial-macro-environment): Provide a macro
expansion of with-suppressed-warnings.
(byte-compile-file-form-with-suppressed-warnings): New byte hunk
handler for the suppressed symbol machinery.
(byte-compile-suppressed-warnings): Ditto for the byteop.
(byte-compile-file-form-defmumble): Ditto.
(byte-compile-form, byte-compile-normal-call)
(byte-compile-normal-call, byte-compile-variable-ref)
(byte-compile-set-default, byte-compile-variable-set)
(byte-compile-function-form, byte-compile-set-default)
(byte-compile-warn-obsolete, byte-compile--declare-var): Pass the
symbol being warned in to byte-compile-warning-enabled-p.

* test/lisp/emacs-lisp/bytecomp-tests.el (test-suppression): New
function.
(bytecomp-test--with-suppressed-warnings): Tests.
2019-06-12 15:59:19 +02:00
Roland Winkler
b8350e52ef Fix to previous commit
* find-dired.el (find-dired-sentinel): Check whether
find-dired-refine-function is non-nil.
2019-06-11 22:17:30 -05:00
Roland Winkler
249902d5ad Allow refining the *Find* buffer of find-dired. (Bug#29513)
* find-dired.el (find-dired-refine-function): New user variable.
(find-dired-sentinel): Use it.  Simplify.
(find-dired-sort-by-filename): New function.
2019-06-11 16:04:45 -05:00
Mattias Engdegård
e92dac3434 Keep auto-revert-mode working when changing buffer file name (bug#36159)
* lisp/autorevert.el (after-set-visited-file-name-hook):
Add unconditionally.
(global-auto-revert-mode): Don't use
`after-set-visited-file-name-hook' here.
(auto-revert-set-visited-file-name): Rename from
`auto-revert--global-set-visited-file-name' and generalise.
* test/lisp/autorevert-tests.el (auto-revert-test06-write-file): New.
2019-06-11 22:15:38 +02:00
Michael Albinus
2b8f9ded06 Minor fixes on tramp-tests.el for w32
* test/lisp/net/tramp-tests.el (tramp-test32-shell-command):
Ignore absence of tput.
(tramp-test43-asynchronous-requests): Don't start watchdog on w32.
2019-06-11 20:28:31 +02:00
Glenn Morris
1903e9964f Merge from origin/emacs-26
5ca093d (origin/emacs-26) Fix doc of 'display-buffer-in-previous-wind...
add2cac lisp/*.el: Minor docstring fixes
2019-06-11 08:38:34 -07:00
Glenn Morris
e545d612df ; Merge from origin/emacs-26
The following commit was skipped:

fdd1b3e Avoid assertion violation when comparing with main-thread
2019-06-11 08:38:34 -07:00
Glenn Morris
e17cda4942 Merge from origin/emacs-26
758e9a8 Revert "Don't mark main_thread (Bug#36155)"
1877b7b Don't mark main_thread (Bug#36155)
4904fb3 More quotation fixes (Bug#35885)
4cc4b5d ; * src/keyboard.c (tool_bar_items): Fix a typo.  (Bug#36143)
b58ecaf Minor copyedits in efaq-w32
48422af Tiny improvement of documentation of major mode conventions
25d44d2 * nt/addpm.c (main): Fix buffer overflow
2019-06-11 08:38:34 -07:00
Pip Cet
ef744119a7 Fix list-processes typo with thread-name
* lisp/simple.el (list-processes--refresh):
Don’t assume thread-name succeeds (Bug#36163).
2019-06-11 08:25:21 -07:00
Eli Zaretskii
c42c4e9c56 Fix shaping of Arabic test when the region is extended
* src/xdisp.c (compute_stop_pos): Set the limit for searching
for changes in text properties such that the limit is never in
the middle of composable text.  (Bug#28312)
2019-06-11 17:45:23 +03:00
Philipp Stephani
c310057342 Add missing indentation declaration to a few macros.
* lisp/window.el (with-temp-buffer-window)
(with-current-buffer-window, with-displayed-buffer-window):
Add missing indentation declaration
2019-06-11 13:34:14 +02:00
Pip Cet
70d5e0ce38 Fix mouse cursor movement in 'select-frame-set-input-focus' (Bug#36165)
* lisp/frame.el (select-frame-set-input-focus): With
'mouse-autoselect-window' use 'set-mouse-pixel-position' to
avoid selecting another window manager window (Bug#36165).
2019-06-11 10:13:36 +02:00
Martin Rudalics
5ca093d281 Fix doc of 'display-buffer-in-previous-window' (Bug#36161)
* doc/lispref/windows.texi (Buffer Display Action Functions):
* lisp/window.el (display-buffer-in-previous-window): Tell
that 'display-buffer-in-previous-window' prefers
non-selected windows (Bug#36161).
2019-06-11 09:28:29 +02:00
Noam Postavsky
0026d0bf9f Don't keep warning about unescaped literals (Bug#36068)
* lisp/emacs-lisp/bytecomp.el (byte-compile-from-buffer): Restore lost
let-binding of lread--unescaped-character-literals, so that unescaped
literals warning will only apply to the form just read.
* test/lisp/emacs-lisp/bytecomp-tests.el
(bytecomp-tests--unescaped-char-literals): Expand test to check that
we don't keep warning about old unescaped literals.
2019-06-10 18:27:22 -04:00
Juanma Barranquero
add2cac586 lisp/*.el: Minor docstring fixes
* lisp/subr.el (definition-prefixes): Reflow docstring.

* lisp/svg.el (svg-create): Doc fix to allow arg higlighting.
(svg-gradient, svg-rectangle): Improve docstring formatting.
2019-06-10 23:47:01 +02:00
Michael Albinus
03b66d23a8 Make tramp-test43-asynchronous-requests working, again
* test/lisp/net/tramp-tests.el (tramp-list-tramp-buffers):
Declare `tramp-list-tramp-buffers'.
(tramp--test-ignore-make-symbolic-link-error)
(tramp--test-ignore-add-name-to-file-error): Improve declaration.
(tramp--test-with-proper-process-name-and-buffer): New macro.
(tramp-test43-asynchronous-requests): Use the macro for timer,
process filter and process sentinel.  Comment the remote file
operation in the timer.  Remove further async events.  Accept
output from all processes.
2019-06-10 17:53:15 +02:00
Michael Albinus
fb39d31e45 Fix quoting problem in Tramp on w32 systems
* lisp/net/tramp-adb.el (tramp-adb-connection-local-default-profile):
* lisp/net/tramp-integration.el (tramp-connection-local-default-profile):
Revert patch from 2019-05-24.  It is fixed differently.

* lisp/net/tramp.el (tramp-encoding-shell):
(tramp-encoding-command-switch)
(tramp-encoding-command-interactive, )
(tramp-unquote-shell-quote-argument): Suppress `shell-file-name'.
(tramp-set-file-uid-gid):
* lisp/net/tramp-sh.el (tramp-find-inline-compress)
(tramp-make-copy-program-file-name):
* lisp/net/tramp-smb.el (tramp-smb-handle-copy-directory):
Use `tramp-unquote-shell-quote-argument'.
2019-06-10 17:48:08 +02:00
Eli Zaretskii
fdd1b3e020 Avoid assertion violation when comparing with main-thread
* src/thread.c (unmark_main_thread): New function.
* src/lisp.h (unmark_main_thread): Prototype it.
* src/alloc.c (garbage_collect_1): Call it after sweeping.
(Bug#33073)

* test/src/thread-tests.el (threads-test-bug33073): New test.
2019-06-10 12:52:31 +02:00
Andreas Schwab
758e9a8ed4 Revert "Don't mark main_thread (Bug#36155)"
This reverts commit 1877b7b4d7.
2019-06-10 12:52:21 +02:00
Mattias Engdegård
f2e4c34de6 Fix copy-paste error in autorevert-test
* test/lisp/autorevert-tests.el: Use correct name to define a remote test.
2019-06-10 12:44:26 +02:00
Andreas Schwab
1877b7b4d7 Don't mark main_thread (Bug#36155)
* thread.c (mark_threads_callback): Don't mark main_thread.
2019-06-10 12:35:35 +02:00
Juanma Barranquero
e214da2dac * src/editfns.c (Fngettext): Fix typos in docstring. 2019-06-10 06:15:09 +02:00
YAMAMOTO Mitsuharu
82052afb24 Avoid empty menu bar on Xaw with cairo
* lwlib/lwlib-utils.c (crxft_font_open_name) [USE_CAIRO]: Return NULL if
font extents are bogus.
2019-06-10 12:57:30 +09:00
YAMAMOTO Mitsuharu
e4f12a1b1f Document exporting/printing text with X core fonts to outline images on cairo
* src/xfns.c (Fx_export_frames) [USE_CAIRO]:
(Fx_print_frames_dialog) [USE_CAIRO && USE_GTK]: Add notes on x font backend.
2019-06-10 10:08:53 +09:00
Dmitry Gutov
0f67be9259 ; Revert "Publicize behavior of log-view-diff at beginning/end of active region"
This reverts commit 82db17d0d1.

Undo the half-baked implementation of the new feature in Git log
buffers until we can do it better (bug#35624).
2019-06-10 03:58:53 +03:00
Dmitry Gutov
2a05c5dbd3 Omit the misplaced and unnecessary shyness qualifier
* lisp/progmodes/ruby-mode.el (ruby-find-library-file):
Omit the misplaced and unnecessary shyness qualifier.
Suggested by Mattias Engdegård <mattiase@acm.org>.
2019-06-10 03:50:44 +03:00
Dmitry Gutov
5f5555da87 Unbreak saving xref--original-window, etc
* lisp/progmodes/xref.el (xref--show-xref-buffer)
(xref--show-defs-buffer-at-bottom): Move major mode calls earlier.
So that local variable values are not lost.
2019-06-10 03:11:59 +03:00
Stefan Kangas
4503310cac Add tests for mail/uudecode.el
* lisp/mail/uudecode.el: Remove redundant :group usage.
* test/lisp/mail/uudecode-resources/uudecoded.txt,
test/lisp/mail/uudecode-resources/uuencoded.txt,
test/lisp/mail/uudecode-tests.el: New files.
2019-06-09 17:07:09 -07:00
Paul Eggert
45c525a685 Fig grammar of count-lines-page
* lisp/textmodes/page.el (count-lines-page):
Say "Page has 1 line", not "Page has 1 lines" (Bug#35981).
2019-06-09 17:00:05 -07:00
Stefan Kangas
abe18f5917 Make bookmark-old-default-file variable obsolete
* lisp/bookmark.el (bookmark-old-default-file):
Redefine as obsolete variable alias for 'bookmark-default-file'.
(bookmark-maybe-load-default-file): Don't try to rename file
'bookmark-old-default-file' (~/.emacs-bkmrks) to new name (Bug#35940).
2019-06-09 16:47:59 -07:00
Stefan Kangas
d11dd6a90c Make bookmark-maybe-message obsolete (Bug#35918)
* lisp/bookmark.el (bookmark-maybe-message):
Redefine as obsolete function alias for 'message'.
(bookmark-write-file): Use a progress reporter.
(bookmark-load-file): Use a progress reporter.
2019-06-09 16:38:59 -07:00
Stefan Kangas
9816aba518 Make `bookmark-file' variable obsolete
* lisp/bookmark.el (bookmark-file): Redefine as obsolete variable
alias for `bookmark-default-file'.  (Bug#35917)
2019-06-09 16:29:21 -07:00
Glenn Morris
3a29764d91 * make-dist: Doc fix for --help re --snapshot (since 201612 change). 2019-06-09 15:55:24 -07:00
Stefan Kangas
323648bf36 Remove interactive spec from bookmark-set-internal (bug#36121)
* lisp/bookmark.el (bookmark-set-internal): Remove interactive spec.
2019-06-09 10:17:13 -07:00
Stefan Kangas
b02af55063 Pacify compiler in paragraphs.el after lexical-binding
* lisp/textmodes/paragraphs.el: Pacify byte compiler.
2019-06-09 10:13:15 -07:00
Stefan Kangas
1af27a1784 Use lexical-binding in password-cache.el and add tests
* lisp/password-cache.el: Use lexical-binding.
* test/lisp/password-cache-tests.el: New file.
2019-06-09 10:08:36 -07:00
Paul Eggert
179b9c44c5 * src/fns.c (cmpfn_eql): Simplify. 2019-06-09 09:18:24 -07:00
Alex Branham
963d4e2426
Use lexical binding for ediff
* lisp/vc/ediff-diff.el:
* lisp/vc/ediff-help.el:
* lisp/vc/ediff-hook.el:
* lisp/vc/ediff-init.el:
* lisp/vc/ediff-merg.el:
* lisp/vc/ediff-vers.el:
* lisp/vc/ediff-wind.el:
* lisp/vc/ediff-mult.el:
* lisp/vc/ediff-ptch.el:
* lisp/vc/ediff.el: Use lexical binding.
(ediff-version): Increase.
(ediff-date): Remove.
2019-06-09 10:00:09 -05:00
Dmitry Gutov
4f479aeb4b Rename xref--pop-to-location to xref-pop-to-location
* lisp/progmodes/xref.el (xref-pop-to-location):
Rename from xref-pop-to-location.  So that third-party
xref-show-definitions-function implementations can use it safely
(bug#36144).  Update all callers.
2019-06-09 17:14:46 +03:00
Dmitry Gutov
ec563971ec Add a built-in alternative for xref-show-definitions-function
* lisp/progmodes/xref.el (xref--transient-buffer-mode-map):
New variable.
(xref--transient-buffer-mode): New major mode.
(xref--button-map): Remove the RET binding (it was unnecessary in
the first place).
(xref--show-common-initialize):
Extract from xref--show-xref-buffer.
(xref--show-defs-buffer-at-bottom): New function.
2019-06-09 17:14:46 +03:00
Eli Zaretskii
4904fb352c More quotation fixes (Bug#35885)
* doc/emacs/text.texi (Quotation Marks): Fix a typo.
* doc/emacs/modes.texi (Minor Modes): Fix another case of
showing quotations.
2019-06-09 11:28:36 +03:00
Stefan Kangas
b7e26952f0 Fix TODO to convert defvar with leading '*' to defcustom
* etc/TODO: Remove done TODO to remove '*' from defvar.
* doc/misc/gnus.texi: Remove leading '*' from defvar example.
* lisp/kermit.el (kermit-esc-char): Convert to defcustom.
* lisp/desktop.el (desktop-header):
* lisp/obsolete/cc-compat.el (c-indent-level)
(c-brace-imaginary-offset, c-brace-offset, c-argdecl-indent)
(c-label-offset, c-continued-statement-offset)
(c-continued-brace-offset): Remove leading '*' from docstring.
* lisp/progmodes/dcl-mode.el: Remove leading '*' from docstring in
comment.
* test/manual/cedet/tests/test.el: Add comment asking if example of
defvar with leading '*' should be removed.
(Bug#35994)  (The previous commit is also for the same bug.)
2019-06-09 10:08:33 +03:00
Stefan Kangas
8c4d114ee2 Fix TODO to remove leading '*' from defcustom
* etc/TODO: Remove done TODO to remove leading '*' from defcustom
doc-strings.
* lisp/ibuffer.el (ibuffer-inline-columns): Remove leading '*' from
doc-string.
2019-06-09 10:07:17 +03:00
Stefan Kangas
f58cae8b37 Mark define-widget-keywords as obsolete
* lisp/widget.el (define-widget-keywords): Mark as obsolete.
(Bug#36065)
2019-06-09 09:59:52 +03:00
Stefan Kangas
e40f1c68b5 Use lexical-binding in underline.el and add tests
* lisp/textmodes/underline.el: Use lexical-binding.
* test/lisp/textmodes/underline-tests.el: New file.
(Bug#36063)
2019-06-09 09:56:03 +03:00
Stefan Kangas
fb6610f59e Checkdoc fixes in lisp/bookmark.el
* lisp/bookmark.el (bookmark-bmenu-inline-header-height)
(bookmark-bmenu-marks-width, bookmark-map, bookmark-quit-flag)
(bookmark-name-from-full-record, bookmark-set-internal)
(bookmark-insert-annotation, bookmark--jump-via)
(bookmark-bmenu-set-header, bookmark-show-annotation)
(bookmark-bmenu-other-window-with-mouse, bookmark-bmenu-relocate):
Checkdoc docstring fixes.  (Bug#35916)
2019-06-09 09:50:39 +03:00
Paul Eggert
1e6396ec3d Fix int overflow bug in ‘equal’
* src/fns.c (internal_equal):
Fix bug when vector lengths exceed INT_MAX.
2019-06-08 23:38:40 -07:00
Paul Eggert
5abaea334c Tune base64 decoding
This improves performance of base64-decode-region by about 7.5% on
my platform, and gets rid of some macros.
* src/fns.c (IS_ASCII, IS_BASE64, IS_BASE64_IGNORABLE)
(READ_QUADRUPLET_BYTE): Remove.
(base64_value_to_char, base64_char_to_value):
Now an array of two arrays.  All uses changed.
(base64url_value_to_char, base64url_char_to_value):
Remove.  All uses changed to the other array.
(base64_char_to_value): Entries are now of type signed char, not
short, since we can assume C99.  Use C99 initializers; this is
clearer and caters to the (theoretical) possibility of systems
that do not use ASCII or do not have 8-bit bytes.  Allow any index
in the range 0..UCHAR_MAX instead of limiting it to 0..127, so
that uses need not check for in-range indexes.  Also record
padding chars.  All uses changed.
(base64_decode_1): Always store number of chars in *NCHARS_RETURN,
for simplicity.  All callers changed.  Speed up the byte-fetching.
2019-06-08 23:32:23 -07:00