As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.
This causes net/kea to fail to compile with clang 19 and libc++ 19,
resulting in errors similar to:
In file included from edns.cc:9:
In file included from ../../../src/lib/exceptions/exceptions.h:11:
/usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value,
| ^
../../../src/lib/dns/name.h:727:16: note: in instantiation of template class 'std::basic_string<unsigned char>' requested here
727 | NameString ndata_;
| ^
/usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
| ^
`NameString` is defined as `std::basic_string<unsigned char>`, which is
no longer possible. So redefine it as a `std::vector<unsigned char>`
instead.
This requires a few adjustments in other places: adjusting the arguments
for the `assign()` method, which for `std::vector` takes a begin and end
iterator, instead of a begin iterator and a size, and replacing the
`append()` method with an equivalent `insert()`.
These changes have also been sent upstream [2].
[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals
[2] https://gitlab.isc.org/isc-projects/kea/-/merge_requests/2410
PR: 280696
Approved by: apevnev@me.com (maintainer)
MFH: 2024Q3
Comparing changes:
7d6751a..b327343
Port changes:
- remove PORTDOCS from Makefile, keep it listed in pkg-plist instead
- set DATADIR to its actual non-standard directory
- remove patch, install with COPYTREE_SHARE instead
- use the more commonly used post-install-DOCS-on target again
- pet portclippy, portfmt, portlint
PR: 280700
As of commit 6c2f347f45 libabsl_flags.so library is gone, switch to
the base library to unbreak the build (this also improves consistency
against other ports).
- Due to an incompatibility with the recent version of textproc/py-textual,
oterm crashes when there are saved chats, with the following error
│ /usr/local/lib/python3.11/site-packages/textual/widget.py:984 in mount │
│ │
│ 981 │ │ if self._closing or self._pruning: ╭──────────── locals ────────────╮ │
│ 982 │ │ │ return AwaitMount(self, []) │ after = None │ │
│ 983 │ │ if not self.is_attached: │ before = None │ │
│ ❱ 984 │ │ │ raise MountError(f"Can't mount widget(s) before {self!r} is mounted") │ self = TabPane(id='chat-1') │ │
│ 985 │ │ # Check for duplicate IDs in the incoming widgets │ widgets = (ChatContainer(),) │ │
│ 986 │ │ ids_to_mount = [ ╰────────────────────────────────╯ │
│ 987 │ │ │ widget_id for widget in widgets if (widget_id := widget.id) is not None │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
MountError: Can't mount widget(s) before TabPane(id='chat-1') is mounted
So add the patch patch-oterm_app_oterm.py, that is a simple workaround
waiting for an official solution by upstream.
- Bump PORTREVISION
