mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-02-01 17:00:36 +00:00
Code Issues Releases Activity

Add an XXX comment for the atomic operation in the __alpha__

Browse Source 
case so that it doesn't confuse more people.  Use the more
correct atomic_clear_16() instead of atomic_clear_short().
This commit is contained in:
Maxime Henrion 2003-04-08 18:35:51 +00:00
parent b8831f8d68
commit 14fd107181
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=113268
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/fxp/if_fxp.c
View File

@ -1383,8 +1383,10 @@ fxp_start(struct ifnet *ifp)
* granularities, we must prevent the card from DMA'ing
* up the status while we update the command field.
* This could cause us to overwrite the completion status.
* XXX This is probably bogus and we're _not_ looking
* for atomicity here.
*/
atomic_clear_short(&sc->fxp_desc.tx_last->tx_cb->cb_command,
atomic_clear_16(&sc->fxp_desc.tx_last->tx_cb->cb_command,
htole16(FXP_CB_COMMAND_S));
#else
sc->fxp_desc.tx_last->tx_cb->cb_command &=