talexander
/
freebsd_amp_hwpstate
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fusefs: fix invalid value for st_birthtime.tv_nsec 

If a file system's on-disk format does not support st_birthtime, it
isn't clear what value it should return in stat(2).  Neither our man
page nor the OpenGroup specifies.  But our convention for UFS and
msdosfs is to return { .tv_sec = -1, .tv_nsec = 0 }.  fusefs is
different.  It returns { .tv_sec = -1, .tv_nsec = -1 }.  It's done that
ever since the initial import in SVN r241519.

Most software apparently handles this just fine.  It must, because we've
had no complaints.  But the Rust standard library will panic when
reading such a timestamp during std::fs::metadata, even if the caller
doesn't care about that particular value.  That's a separate bug, and
should be fixed.

Change our invalid value to match msdosfs and ufs, pacifying the Rust
standard library.

PR:		276602
MFC after:	1 week
Sponsored by:	Axcient
Reviewed by:	emaste
Differential Revision: https://reviews.freebsd.org/D43590
This commit is contained in:
Alan Somers 2024-01-25 08:19:37 -07:00
parent cd724c2592
commit 55b80e2ca5
4 changed files with 25 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sys/fs/fuse/fuse_internal.c
View File

@ -325,7 +325,6 @@ fuse_internal_cache_attrs(struct vnode *vp, struct fuse_attr *attr,
else
return;
vattr_null(vp_cache_at);
vp_cache_at->va_fsid = mp->mnt_stat.f_fsid.val[0];
vp_cache_at->va_fileid = attr->ino;
vp_cache_at->va_mode = attr->mode & ~S_IFMT;

7
sys/fs/fuse/fuse_node.c
View File

@ -155,7 +155,14 @@ fuse_vnode_init(struct vnode *vp, struct fuse_vnode_data *fvdat,
{
fvdat->nid = nodeid;
LIST_INIT(&fvdat->handles);
vattr_null(&fvdat->cached_attrs);
fvdat->cached_attrs.va_birthtime.tv_sec = -1;
fvdat->cached_attrs.va_birthtime.tv_nsec = 0;
fvdat->cached_attrs.va_fsid = VNOVAL;
fvdat->cached_attrs.va_gen = 0;
fvdat->cached_attrs.va_rdev = NODEV;
if (nodeid == FUSE_ROOT_ID) {
vp->v_vflag |= VV_ROOT;
}

15
tests/sys/fs/fusefs/getattr.cc
View File

@ -246,12 +246,15 @@ TEST_F(Getattr, ok)
EXPECT_EQ(ino, sb.st_ino);
EXPECT_EQ(S_IFREG | 0644, sb.st_mode);
//st_birthtim and st_flags are not supported by protocol 7.8. They're
//only supported as OS-specific extensions to OSX.
//EXPECT_EQ(, sb.st_birthtim);
//EXPECT_EQ(, sb.st_flags);
//FUSE can't set st_blksize until protocol 7.9
/*
* st_birthtim and st_flags are not supported by the fuse protocol.
* They're only supported as OS-specific extensions to OSX. For
* birthtime, the convention for "not supported" is "negative one
* second".
*/
EXPECT_EQ(-1, sb.st_birthtim.tv_sec);
EXPECT_EQ(0, sb.st_birthtim.tv_nsec);
EXPECT_EQ(0u, sb.st_flags);
}
/*

15
tests/sys/fs/fusefs/lookup.cc
View File

@ -112,12 +112,15 @@ TEST_F(Lookup, attr_cache)
// fuse(4) does not _yet_ support inode generations
//EXPECT_EQ(generation, sb.st_gen);
//st_birthtim and st_flags are not supported by protocol 7.8. They're
//only supported as OS-specific extensions to OSX.
//EXPECT_EQ(, sb.st_birthtim);
//EXPECT_EQ(, sb.st_flags);
//FUSE can't set st_blksize until protocol 7.9
/*
* st_birthtim and st_flags are not supported by the fuse protocol.
* They're only supported as OS-specific extensions to OSX. For
* birthtime, the convention for "not supported" is "negative one
* second".
*/
EXPECT_EQ(-1, sb.st_birthtim.tv_sec);
EXPECT_EQ(0, sb.st_birthtim.tv_nsec);
EXPECT_EQ(0u, sb.st_flags);
}
/*