talexander
/
freebsd_amp_hwpstate
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

acl_equiv_mode_np: zero mode on just inited ACL 

You can't return 0 and not write the mode if mode_p is non-NULL.  That
violates the API contract and in common usage leaves stack trash in
*mode_p.

The acl_equiv_mode_test test passed by accident.

Reviewed by:	kevans, markj
Sponsored by:	DARPA
Differential Revision:	https://reviews.freebsd.org/D43278
This commit is contained in:
Brooks Davis 2024-01-03 16:34:39 +00:00
parent 8b144c015c
commit 85c9d36497
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/libc/posix1e/acl_equiv_mode_np.c
View File

@ -49,7 +49,7 @@ acl_equiv_mode_np(acl_t acl, mode_t *mode_p)
/* Linux returns 0 for ACL returned by acl_init() */ /* Linux returns 0 for ACL returned by acl_init() */
if (_acl_brand(acl) == ACL_BRAND_UNKNOWN && acl->ats_acl.acl_cnt == 0) if (_acl_brand(acl) == ACL_BRAND_UNKNOWN && acl->ats_acl.acl_cnt == 0)
return (0); goto done;
// TODO: Do we want to handle ACL_BRAND_NFS4 in this function? */ // TODO: Do we want to handle ACL_BRAND_NFS4 in this function? */
if (_acl_brand(acl) != ACL_BRAND_POSIX) if (_acl_brand(acl) != ACL_BRAND_POSIX)
@ -91,6 +91,7 @@ acl_equiv_mode_np(acl_t acl, mode_t *mode_p)
} }
} }
done:
if (mode_p != NULL) if (mode_p != NULL)
*mode_p = ret_mode; *mode_p = ret_mode;