talexander
/
freebsd_amp_hwpstate
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mpi3mr: Remove unused fields in struct mpi3mr_cmd 

All of these fields are either unused, or just initialized. Remove
them. This saves about 1MB of memory for the cards that I have which can
do 8k transactions at once.

Sponsored by:		Netflix
Reviewed by:		mav, jhb
Differential Revision:	https://reviews.freebsd.org/D42538
This commit is contained in:
Warner Losh 2023-11-28 18:49:01 -07:00
parent b411372b7d
commit a2b046620c
2 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/dev/mpi3mr/mpi3mr.c
View File

@ -4985,12 +4985,9 @@ mpi3mr_get_command(struct mpi3mr_softc *sc)
cmd->data_dir = 0; cmd->data_dir = 0;
cmd->ccb = NULL; cmd->ccb = NULL;
cmd->targ = NULL; cmd->targ = NULL;
cmd->max_segs = 0;
cmd->lun = 0;
cmd->state = MPI3MR_CMD_STATE_BUSY; cmd->state = MPI3MR_CMD_STATE_BUSY;
cmd->data = NULL; cmd->data = NULL;
cmd->length = 0; cmd->length = 0;
cmd->out_len = 0;
out: out:
mtx_unlock(&sc->cmd_pool_lock); mtx_unlock(&sc->cmd_pool_lock);
return cmd; return cmd;

6
sys/dev/mpi3mr/mpi3mr.h
View File

@ -456,19 +456,13 @@ struct mpi3mr_cmd {
union ccb *ccb; union ccb *ccb;
void *data; void *data;
u_int length; u_int length;
u_int out_len;
struct uio uio;
struct iovec iovec[MPI3MR_IOVEC_COUNT];
u_int max_segs;
struct mpi3mr_target *targ; struct mpi3mr_target *targ;
u_int lun;
u_int data_dir; u_int data_dir;
u_int state; u_int state;
bus_dmamap_t dmamap; bus_dmamap_t dmamap;
struct scsi_sense_data *sense; struct scsi_sense_data *sense;
struct callout callout; struct callout callout;
bool callout_owner; bool callout_owner;
mpi3mr_cmd_callback_t *timeout_handler;
U16 hosttag; U16 hosttag;
U8 req_qidx; U8 req_qidx;
Mpi3SCSIIORequest_t io_request; Mpi3SCSIIORequest_t io_request;