talexander
/
freebsd_amp_hwpstate
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Explain what we're doing in pcic_pci_shutdown a little better. Try to 

explain the subtle side effects that are going to happen and why we go
ahead and ack the interrupt source.  This stuff is tricky to get
right.

Also, emperical tests have shown that doing a shutdown in attach to be
ineffectual, so remove it from there.  Analysis of the code paths
shows that nearly identical writes to these registers happen in later
parts of the code.  The hanging problem on thinkpads when we change
the interrupt routing type is something else.
This commit is contained in:
Warner Losh 2001-08-24 17:29:42 +00:00
parent e5dfa86a70
commit d625c99d74
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
sys/pccard/pcic_pci.c
View File

@ -677,13 +677,26 @@ pcic_pci_shutdown(device_t dev)
sp = &sc->slots[0];
/*
* Turn off the power to the slot before we do anything
* with it.
* Turn off the power to the slot in an attempt to
* keep the system from hanging on reboot. We also turn off
* card interrupts in an attempt to control interrupt storms.
* on some (all?) this has the effect of also turning off
* card status change interrupts. A side effect of writing 0
* to INT_GEN is that the card is placed into "reset" mode
* where nothing happens until it is taken out of "reset"
* mode.
*/
sp->putb(sp, PCIC_INT_GEN, 0);
sp->putb(sp, PCIC_POWER, 0);
/* Ack any pending interrupts */
/*
* Writing to INT_GEN can cause an interrupt, so we blindly
* ack all possible interrupts here. Reading the stat change
* shouldn't be necessary, but some TI chipsets need it in the
* normal course of operations, so we do it here too. We can't
* lose any interrupts after this point, so go ahead and ack
* everything. The bits in INT_GEN clear upon reading them.
*/
bus_space_write_4(sp->bst, sp->bsh, 0, 0xffffffff);
sp->getb(sp, PCIC_STAT_CHG);
}
@ -765,8 +778,6 @@ pcic_pci_attach(device_t dev)
sc->csc_route = pcic_intr_path;
sc->func_route = pcic_intr_path;
pcic_pci_shutdown(dev);
if (itm && itm->init)
itm->init(dev);
else