talexander
/
freebsd_amp_hwpstate
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix logic bug in pci bridge code. For a PCI-PCI bridge, secondary 

should be <= than subordinate, not the other way around.

They are both true if the bridge is not cascaded (i.e., twin-channel
scsi/e-net adapters won't be affected by this bug), which is probably why
it was unnoticed until today.
This commit is contained in:
Satoshi Asami 1996-04-25 06:04:27 +00:00
parent 2a8d579fc8
commit f8176d838c
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/pci/pci.c
View File

@ -1,6 +1,6 @@
/**************************************************************************
**
** $Id: pci.c,v 1.47 1996/04/07 17:32:35 bde Exp $
** $Id: pci.c,v 1.48 1996/04/14 20:14:36 se Exp $
**
** General subroutines for the PCI bus.
** pci_configure ()
@ -731,7 +731,7 @@ pci_bus_config (void)
** check for uninitialized bridge.
*/
if (!(primary < secondary
&& subordinate <= secondary
&& secondary <= subordinate
&& bus_no == primary))
{
printf ("\tINCORRECTLY or NEVER CONFIGURED.\n");

4
sys/pci/pci.c
View File

@ -1,6 +1,6 @@
/**************************************************************************
**
** $Id: pci.c,v 1.47 1996/04/07 17:32:35 bde Exp $
** $Id: pci.c,v 1.48 1996/04/14 20:14:36 se Exp $
**
** General subroutines for the PCI bus.
** pci_configure ()
@ -731,7 +731,7 @@ pci_bus_config (void)
** check for uninitialized bridge.
*/
if (!(primary < secondary
&& subordinate <= secondary
&& secondary <= subordinate
&& bus_no == primary))
{
printf ("\tINCORRECTLY or NEVER CONFIGURED.\n");