talexander/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Releases Activity

diffoscope: fix broken build due to cbfs tests for now

Browse Source 
The diffoscope build broke due to failing tests related to cbfs when
coreboot-utils was updated from 4.20 to 4.21 with commit
be6408699e.
Thanks to aij on github for reporting this issue and bisecting to find
the change in nixpkgs that introduced the issue.
The tests disabled in this commit should be re-enabled when diffoscope or
coreboot fix the underlying issue.

See: https://github.com/NixOS/nixpkgs/issues/256896
This commit is contained in:
Martin Schwaighofer
2023-09-27 12:38:45 +02:00
parent cc27cd5fdf
commit 7ef43e566c
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkgs/tools/misc/diffoscope/default.nix
View File

@@ -245,8 +245,13 @@ python3.pkgs.buildPythonApplication rec {
"test_symlink_root"
];
disabledTestPaths = [
# fails due to https://github.com/NixOS/nixpkgs/issues/256896
# should be removed once that issue is resolved in coreboot or diffoscope
"tests/comparators/test_cbfs.py"
]
# Flaky tests on Darwin
disabledTestPaths = lib.optionals stdenv.isDarwin [
++ lib.optionals stdenv.isDarwin [
"tests/comparators/test_git.py"
"tests/comparators/test_java.py"
"tests/comparators/test_uimage.py"