talexander/organic
1
0
Fork 0
Code Issues Pull Requests Releases Activity

Use static strings for CustomError.
All checks were successful
rustfmt Build rustfmt has succeeded
Details
rust-test Build rust-test has succeeded
Details
rust-build Build rust-build has succeeded
Details
rust-foreign-document-test Build rust-foreign-document-test has succeeded
Details

Browse Source 
This resulted in a 20% speedup.
This commit is contained in:
Tom Alexander 2023-09-29 11:26:23 -04:00
parent 90433aa55f
commit 1b7326eafe
Signed by: talexander
GPG Key ID: D3A179C9A53C0EDE
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/error/error.rs
View File

@ -4,10 +4,9 @@ use nom::IResult;
pub(crate) type Res<T, U> = IResult<T, U, CustomError<T>>; pub(crate) type Res<T, U> = IResult<T, U, CustomError<T>>;
// TODO: MyError probably shouldn't be based on the same type as the input type since it's used exclusively with static strings right now.
#[derive(Debug)] #[derive(Debug)]
pub enum CustomError<I> { pub enum CustomError<I> {
MyError(MyError<I>), MyError(MyError<&'static str>),
Nom(I, ErrorKind), Nom(I, ErrorKind),
IO(std::io::Error), IO(std::io::Error),
} }
@ -31,3 +30,9 @@ impl<I> From<std::io::Error> for CustomError<I> {
CustomError::IO(value) CustomError::IO(value)
} }
} }
impl<I> From<&'static str> for CustomError<I> {
fn from(value: &'static str) -> Self {
CustomError::MyError(MyError(value))
}
}